Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone version to php informational system check output #16660

Merged
merged 3 commits into from Nov 4, 2020
Merged

Add timezone version to php informational system check output #16660

merged 3 commits into from Nov 4, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 3, 2020 •
edited

Description:

fix #16657

Information may be useful when troubleshooting some issues. Only needed though when Matomo is installed

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur
Add timezone version to php informational system check output
476b084 
fix #16657

Information may be useful when troubleshooting some issues. Only needed though when Matomo is installed
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 3, 2020
@tsteur tsteur added this to the 4.1.0 milestone Nov 3, 2020
@tsteur tsteur mentioned this pull request Nov 3, 2020
Closed
@sgiehl
Copy link
Member

sgiehl commented Nov 4, 2020

@tsteur would be good to merge. Not sure if that topic might be worth to create a small FAQ for. Something like What can I do if my selected timezone doesn't use the correct offset

@tsteur
Copy link
Member Author

tsteur commented Nov 4, 2020

@sgiehl had a quick look on how to do this but doesn't seem straight forward or can't find any good info on this. Seems the best/fastest way is typically to update the PHP version? see eg https://www.generacodice.com/en/articolo/838267/How-to-update-timezonedb-in-PHP-(updating-timezones-info) unless I'm missing something?

@sgiehl
Copy link
Member

sgiehl commented Nov 4, 2020

Instead of updating PHP itself it's also possible to install/update the pecl package timezonedb

@tsteur
Copy link
Member Author

tsteur commented Nov 4, 2020

created https://matomo.org/faq/troubleshooting/how-do-i-fix-if-a-timezone-that-doesnt-use-the-correct-offset/

@tsteur tsteur merged commit afae5ef into 4.x-dev Nov 4, 2020
@tsteur tsteur deleted the 16657 branch November 4, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Website time zone setting for Canada - Whitehorse and Canada - Dawson does not observe now-permanent UTC-7
2 participants
@tsteur @sgiehl