@tsteur opened this Pull Request on November 2nd 2020 Member

Description:

refs https://github.com/matomo-org/matomo/pull/14444#pullrequestreview-521623030 the tests before was actually never really working. We need to unset cookie values when a cookie is being deleted.

Fix failing test https://travis-ci.com/github/matomo-org/matomo/jobs/425027304#L916-L925

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
This Pull Request was closed on November 3rd 2020
Powered by GitHub Issue Mirror