Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #16658

Merged
merged 1 commit into from Nov 3, 2020
Merged

Fix build #16658

merged 1 commit into from Nov 3, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 2, 2020 •
edited by sgiehl

Description:

refs #14444 (review) the tests before was actually never really working. We need to unset cookie values when a cookie is being deleted.

Fix failing test https://travis-ci.com/github/matomo-org/matomo/jobs/425027304#L916-L925

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 2, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 2, 2020
@sgiehl sgiehl merged commit 0739af5 into 4.x-dev Nov 3, 2020
@sgiehl sgiehl deleted the fixsessioncookietest branch November 3, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl