Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #16656

Closed
wants to merge 5 commits into from
Closed

Fix build #16656

wants to merge 5 commits into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 2, 2020

Description:

refs #14444 (review)

Fix failing test https://travis-ci.com/github/matomo-org/matomo/jobs/425027304#L916-L925

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 2, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 2, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 2, 2020
@tsteur tsteur closed this Nov 2, 2020
@tsteur tsteur deleted the deleteCookie branch November 2, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant