don't install unneeded polyfills with composer #16653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
Task
|
That package actually was already automatically removed with a composer update. See #16649 |
|
Ah, I didn't see that PR. |
|
Yes. Shouldn't hurt to prevent installing those polyfills nevertheless |
sgiehl
approved these changes
Nov 2, 2020
|
@Findus23 @sgiehl the tests are failing see https://travis-ci.com/github/matomo-org/matomo/jobs/424314293 |
|
guess merging in the latest changes should fix it... |
|
there's a test now failing. not sure if it is due to this? https://travis-ci.com/github/matomo-org/matomo/jobs/424766921#L925 @sgiehl @Findus23 |
|
The same failure seems to be on 4.x-dev without this PR: https://travis-ci.com/github/matomo-org/matomo/jobs/424766869#L921 |
|
That was caused by the cookie PR. See #14444 (review) |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/symfony/polyfill/blob/main/README.md#design
This removes
symfony/polyfill-php56on the nextcomposer install