@Findus23 opened this Pull Request on November 2nd 2020 Member

see https://github.com/symfony/polyfill/blob/main/README.md#design

This removes symfony/polyfill-php56 on the next composer install

@sgiehl commented on November 2nd 2020 Member

That package actually was already automatically removed with a composer update. See #16649

@Findus23 commented on November 2nd 2020 Member

Ah, I didn't see that PR.
We could still add those lines in case any other dependency adds polyfills.

@sgiehl commented on November 2nd 2020 Member

Yes. Shouldn't hurt to prevent installing those polyfills nevertheless

@tsteur commented on November 2nd 2020 Member
@sgiehl commented on November 2nd 2020 Member

guess merging in the latest changes should fix it...

@tsteur commented on November 2nd 2020 Member

there's a test now failing. not sure if it is due to this? https://travis-ci.com/github/matomo-org/matomo/jobs/424766921#L925 @sgiehl @Findus23

@Findus23 commented on November 2nd 2020 Member

The same failure seems to be on 4.x-dev without this PR: https://travis-ci.com/github/matomo-org/matomo/jobs/424766869#L921

@sgiehl commented on November 2nd 2020 Member
This Pull Request was closed on November 2nd 2020
Powered by GitHub Issue Mirror