Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extra argument to reArchiveReport start date. #16634

Merged
merged 1 commit into from Oct 30, 2020
Merged

Make extra argument to reArchiveReport start date. #16634

merged 1 commit into from Oct 30, 2020

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 30, 2020
@diosmosis diosmosis added this to the 4.0.0-RC milestone Oct 30, 2020
@diosmosis
Copy link
Member Author

FYI @tsteur for AbTesting change

@tsteur
Copy link
Member

tsteur commented Oct 30, 2020

Date should work too. I thought initially number of days as integer but this way using Date should be easier since we have the data in the DB most of the time and won't need to do any math 👍

@diosmosis diosmosis merged commit 5e7ed31 into 4.x-dev Oct 30, 2020
@diosmosis diosmosis deleted the re-archive-days branch October 30, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur