Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to demo #16631

Merged
merged 1 commit into from Nov 1, 2020
Merged

Update link to demo #16631

merged 1 commit into from Nov 1, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 30, 2020

We're changing it cloud since it's faster there (no proxysite in the middle)

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 30, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Oct 30, 2020
@sgiehl
Copy link
Member

sgiehl commented Oct 30, 2020

There are actually a few more occurrences of the demo url in the code. Not sure if it should be updated anywhere else...

@tsteur
Copy link
Member Author

tsteur commented Nov 1, 2020

@sgiehl it should be fine for now. There's the prefixUrl in some template but not sure what it is used for etc. Can change later if needed

@tsteur tsteur merged commit 53c1cc1 into 4.x-dev Nov 1, 2020
@tsteur tsteur deleted the demolinkupdate branch November 1, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl