change info logs to debug #16626
Merged
change info logs to debug #16626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
mattab
reviewed
Oct 29, 2020
| @@ -828,7 +828,7 @@ public function invalidateArchivedReportsForSitesThatNeedToBeArchivedAgain($idSi | |||
| $segmentDatesToInvalidate = $this->segmentArchiving->getSegmentArchivesToInvalidateForNewSegments($idSiteToInvalidate); | |||
|
|
|||
| foreach ($segmentDatesToInvalidate as $info) { | |||
| $this->logger->info(' Segment "{segment}" was created or changed recently and will therefore archive today (for site ID = {idSite})', [ | |||
| $this->logger->debug(' Segment "{segment}" was created or changed recently and will therefore archive today (for site ID = {idSite})', [ | |||
There was a problem hiding this comment.
this one would be helpful probably as info
mattab
reviewed
Oct 29, 2020
| @@ -868,7 +868,7 @@ private function invalidateRecentDate($dateStr, $idSite) | |||
| return; | |||
| } | |||
|
|
|||
| $this->logger->info(" Will invalidate archived reports for $dateStr in site ID = {idSite}'s timezone ({date}).", [ | |||
| $this->logger->debug(" Will invalidate archived reports for $dateStr in site ID = {idSite}'s timezone ({date}).", [ | |||
There was a problem hiding this comment.
if these things are not supposed to happen often, it would be useful to log as info? in my ticket i just meant the 2 extra lines with no useful info displayed for each site, i didn't mean we necessarily remove every line as these look useful (as long as they aren't expected to be triggered all the time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16619