Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove core:archive output "Checking for queued invalidations / Done invalidating" #16619

Closed
mattab opened this issue Oct 28, 2020 · 3 comments · Fixed by #16626
Closed

remove core:archive output "Checking for queued invalidations / Done invalidating" #16619

mattab opened this issue Oct 28, 2020 · 3 comments · Fixed by #16626
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@mattab
Copy link
Member

mattab commented Oct 28, 2020

It would be great to hide the new output text (bold below) in core:archive output in Matomo 4, as this text is not helpful

INFO [2020-10-28 00:31:39] 39985 Starting Matomo reports archiving...
INFO [2020-10-28 00:31:39] 39985 Start processing archives for site 1.
INFO [2020-10-28 00:31:39] 39985 Checking for queued invalidations...
INFO [2020-10-28 00:31:39] 39985 Done invalidating
INFO [2020-10-28 00:31:39] 39985 Finished archiving for site 1, 0 API requests, Time elapsed: 0.028s [1 / 2 done]
INFO [2020-10-28 00:31:39] 39985 Start processing archives for site 2.
INFO [2020-10-28 00:31:39] 39985 Checking for queued invalidations...
INFO [2020-10-28 00:31:39] 39985 Done invalidating
INFO [2020-10-28 00:31:39] 39985 Finished archiving for site 2, 0 API requests, Time elapsed: 0.011s [2 / 2 done]
INFO [2020-10-28 00:31:39] 39985 Done archiving!
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 28, 2020
@mattab mattab added this to the 4.0.0-RC milestone Oct 28, 2020
@tsteur tsteur modified the milestones: 4.0.0-RC, 4.2.0 Oct 28, 2020
@tsteur
Copy link
Member

tsteur commented Oct 28, 2020

@diosmosis we could set them for now to debug? Otherwise we can also leave them there for now and review in a year to first see how practical it is to have it / not have it etc.

@diosmosis
Copy link
Member

There can be logs in between those two, might be a bit confusing if they show up w/o context. We could make all the invalidating messages debug, I guess.

@tsteur
Copy link
Member

tsteur commented Oct 28, 2020

I have generally no big preference. I reckon often those messages aren't even shown anyway if there are still invalidations left to do etc.

@diosmosis diosmosis mentioned this issue Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging a pull request may close this issue.

change info logs to debug matomo-org/matomo
3 participants
@diosmosis @tsteur @mattab