Automatically add phpunit group name to a plugin php test #16615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
commented
Oct 27, 2020
| @@ -58,6 +58,19 @@ abstract class SystemTestCase extends TestCase | |||
| */ | |||
| public static $fixture; | |||
|
|
|||
| public function setGroups(array $groups): void | |||
There was a problem hiding this comment.
it's officially an internal method but seemed for me easiest way to make this work. Not sure there's another way.
tsteur
commented
Oct 27, 2020
| @@ -38,6 +39,13 @@ public function setUp(): void | |||
| parent::setUp(); | |||
| } | |||
|
|
|||
| public function test_TestCaseHasSetGroupsMethod() | |||
There was a problem hiding this comment.
added a test so we would notice when this method is no longer there
sgiehl
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #16612
fixing this here as this way we can restart all plugin tests and make sure they are included in the test runs