only look for done_ok archives when doing usable archive check #16610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook for done_ok archives in said check
diosmosis
added
not-in-changelog
sgiehl
reviewed
Oct 28, 2020
| return false; | ||
| } | ||
|
|
||
| return Date::factory($archiveIdAndVisits[4])->getDatetime(); |
There was a problem hiding this comment.
Not really related to this PR: But should we maybe change getArchiveIdAndVisits to return something more meaningful. Without looking into the method it's hard to understand what the forth element of the returned array actual is.
Personally I would prefer to have at least named array keys or an object (or class) with defined properties, that would make the code easier to read and to understand...
sgiehl
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16594