Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overwriting rows_to_display property to ensure storing viewDatable settings works #16601

Merged
merged 1 commit into from Oct 21, 2020
Merged

Allow overwriting rows_to_display property to ensure storing viewDatable settings works #16601

merged 1 commit into from Oct 21, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 21, 2020

@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 21, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Oct 21, 2020
@tsteur
Copy link
Member

tsteur commented Oct 21, 2020 •
edited

This also fixes #16349

@tsteur tsteur merged commit ee471c2 into 4.x-dev Oct 21, 2020
@tsteur tsteur deleted the fixchartconfig branch October 21, 2020 19:05
@tsteur tsteur mentioned this pull request Oct 21, 2020
Closed
@MichaIng
Copy link
Contributor

Just tested it and can confirm the issue is fixed for us as well, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

Setting parameters rows_to_display is not allowed
3 participants
@sgiehl @tsteur @MichaIng