Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MobileMessaging twig fix for 'Variable "ajax" does not exist.' #16600

Merged
merged 1 commit into from Oct 21, 2020
Merged

MobileMessaging twig fix for 'Variable "ajax" does not exist.' #16600

merged 1 commit into from Oct 21, 2020

Conversation

Findus23
Copy link
Member

A fatal error occurred
The following error just broke Matomo (v4.0.0-b3):

Variable "ajax" does not exist.
in /home/lukas/public_html/matomophp8/plugins/MobileMessaging/templates/index.twig line 156

I am not sure if a twig update broke this or it never worked anyway

@Findus23 Findus23 added the Needs Review PRs that need a code review label Oct 21, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Oct 21, 2020
sgiehl
sgiehl approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find 👍

@tsteur tsteur merged commit f4fe284 into 4.x-dev Oct 21, 2020
@tsteur tsteur deleted the twig-ajax branch October 21, 2020 19:13
@mattab mattab changed the title fix twig template for MobileMessaging MobileMessaging twig fix for 'Variable "ajax" does not exist.' Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Findus23 @sgiehl @tsteur