Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated implode warning #16599

Merged
merged 1 commit into from Oct 20, 2020
Merged

Fix deprecated implode warning #16599

merged 1 commit into from Oct 20, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 20, 2020

In plugins/Ecommerce/templates/_actionTooltip.twig we use {{ action.productViewCategories|implode(', ') }} which causes Deprecated - implode(): Passing glue string after array is deprecated. Swap the parameters - Matomo 4.0.0-b3 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) (Module: Live, Action: getLastVisitsDetails, In CLI mode: false).

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 20, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Oct 20, 2020
@diosmosis diosmosis merged commit a93aea5 into 4.x-dev Oct 20, 2020
@diosmosis diosmosis deleted the implodetwig branch October 20, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants