Updater: Check if column exist only shortly before it is needed #16589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just in case there are multiple updates running at the same time (eg when 2 users click on `update` in the UI or this might also happen in Matomo for WordPress). Then the update on `log_visit...SET visitor_seconds_since_first = visitor_days_since_first * 86400, ` might take a while and meanwhile another concurrent job has removed that column already. Bit hard to explain but basically we want to get this information only shortly before it is needed
tsteur
added
not-in-changelog
tsteur
changed the title
sgiehl
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case there are multiple updates running at the same time (eg when 2 users click on
updatein the UI or this might also happen in Matomo for WordPress). Then the update onlog_visit...SET visitor_seconds_since_first = visitor_days_since_first * 86400,might take a while and meanwhile another concurrent job has removed that column already. Bit hard to explain but basically we want to get this information only shortly before it is needed