Pass string parameters to DB query instead of object #16588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Matomo for WordPress this caused the tests to fail. I have now worked around this to ensure it won't cause any issues in Matomo for WordPress anymore (matomo-org/matomo-for-wordpress@ffe92d1#diff-c4e75ddbbcdde3ba408b5a87e273371dd3420a5d0b90a87bb4295e81787cdc31R242-R244) when this happens again but figured it be still good to pass strings directly here just in case it somehow causes other issues somehow :)
tsteur
added
not-in-changelog
diosmosis
reviewed
Oct 19, 2020
core/DataAccess/Model.php
Outdated
| @@ -377,7 +377,7 @@ public function deleteOlderArchives(Parameters $params, $name, $tsArchived, $idA | |||
|
|
|||
| $sql = "SELECT idarchive FROM `$numericTable` WHERE idsite = ? AND date1 = ? AND date2 = ? AND period = ? AND name = ? AND ts_archived < ? AND idarchive < ?"; | |||
|
|
|||
| $idArchives = Db::fetchAll($sql, [$params->getSite()->getId(), $dateStart, $dateEnd, $params->getPeriod()->getId(), $name, $tsArchived, $idArchive]); | |||
| $idArchives = Db::fetchAll($sql, [$params->getSite()->getId(), $dateStart . '', $dateEnd . '', $params->getPeriod()->getId(), $name, $tsArchived, $idArchive]); | |||
There was a problem hiding this comment.
Would it be good to use ->getDatetime()? Otherwise good to merge.
There was a problem hiding this comment.
👍 Good one. So maybe partially it could have been buggy before?
There was a problem hiding this comment.
Maybe, I remember testing this and it working at least on my local setup...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Matomo for WordPress this caused the tests to fail. I have now worked around this to ensure it won't cause any issues in Matomo for WordPress anymore (matomo-org/matomo-for-wordpress@ffe92d1#diff-c4e75ddbbcdde3ba408b5a87e273371dd3420a5d0b90a87bb4295e81787cdc31R242-R244) when this happens again but figured it be still good to pass strings directly here just in case it somehow causes other issues somehow :)