@stevenseeley opened this Pull Request on October 16th 2020 Contributor

Hi Guys,

I was having some issues when downloading files as the response headers were not set when php-curl isn’t installed.

Instead of opening an issue, I decided to create a simple patch that fixes the file download bug and set the response headers correctly.

Kind regards,

Steve

@sgiehl commented on October 20th 2020 Member

@stevenseeley Would you mind explaining your issue a bit more? Which file did you try downloading?
I would like to reproduce that locally in order to check if the changes are solving it

@stevenseeley commented on October 20th 2020 Contributor

@stevenseeley Would you mind explaining your issue a bit more? Which file did you try downloading?
I would like to reproduce that locally in order to check if the changes are solving it

Hi @sgiehl, yes when using the Http::downloadChunk static method which is used by several of your API's (such as downloadFreeGeoIPDB) there is a check for content-length and if it's 0 it will thrown an exception see here

It's only set when using php-curl, for example when falling back to fopen this header (and all the others) is not set. I hope that makes sense!

This Pull Request was closed on October 21st 2020
Powered by GitHub Issue Mirror