Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New console command config:delete to delete a key #16576

Closed
gramakri opened this issue Oct 15, 2020 · 2 comments · Fixed by #17956
Closed

New console command config:delete to delete a key #16576

gramakri opened this issue Oct 15, 2020 · 2 comments · Fixed by #17956
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
Backlog (Help wan...

Comments

@gramakri
Copy link

There is already a config:set to add a key in a section. Would be helpful to have a config:delete to delete a key in a section as well. This would be especially useful when combined with --value to remove an entry from array keys like severs[], Plugins[].
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Oct 15, 2020
@tsteur tsteur added this to the Backlog (Help wanted) milestone Oct 15, 2020
@tsteur
Copy link
Member

tsteur commented Oct 15, 2020

Thanks for suggesting this feature @gramakri

If someone is keen to work on this: It could work similar to https://github.com/matomo-org/matomo/blob/4.0.0-b3/plugins/CoreAdminHome/Commands/SetConfig.php#L19-L86 in a new DeleteConfig class. It's probably quite easy to implement and we will be happy to review.

@mwithheld
Copy link
Contributor

I've put in a PR for this at
#17956

@mwithheld mwithheld mentioned this issue Sep 3, 2021
Merged
11 tasks
@sgiehl sgiehl linked a pull request Sep 3, 2021 that will close this issue
Add CLI config:get and config:delete #17956
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title console (cli): Add config:delete to delete a key New console command: Add config:delete to delete a key Oct 6, 2021
@justinvelluppillai justinvelluppillai changed the title New console command: Add config:delete to delete a key New console command config:delete to delete a key Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging a pull request may close this issue.

Add CLI config:get and config:delete
3 participants
@gramakri @tsteur @mwithheld