Set minimal height of all textareas to 100px #16566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
|
@sgiehl if I understand things correctly that would go into if (hasUiControl(field, 'textarea')) {
M.textareaAutoResize...
}not sure it works but this be generally speaking the correct place I reckon. If you need the DOM element I think there's also a method |
|
@tsteur good hint. there was actually a autoresize in that file already, that didn't work anymore. It should work again now... |
sgiehl
force-pushed
the
textareaheight
branch
from
e653f1e
to
414f2df
Compare
|
👍 works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure all textareas fit the height of their content, we could use this javascript
But actually I'm not sure where to add it properly....
fixes #16560