Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP-DI to 6.3.0 for PHP 8 support #16562

Merged
merged 1 commit into from Oct 13, 2020
Merged

Update PHP-DI to 6.3.0 for PHP 8 support #16562

merged 1 commit into from Oct 13, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 12, 2020

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 12, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Oct 12, 2020
@Findus23
Copy link
Member

And indeed this branch works without any error on PHP 8

grafik

🎉 🎉 🎉

@sgiehl sgiehl merged commit 2494656 into 4.x-dev Oct 13, 2020
@sgiehl sgiehl deleted the phpdi630 branch October 13, 2020 06:30
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tsteur @Findus23 @sgiehl @mattab