@sgiehl opened this Pull Request on October 12th 2020 Member

fixes #16259

@sgiehl commented on October 13th 2020 Member

@tsteur Do we also need a possibility to define the default value for new websites, or maybe the possibility to disable the features in config, so it's not possible to enable them in UI?

@tsteur commented on October 13th 2020 Member

Haven't looked at the PR so not sure what is implemented. I think a global system setting to disable the feature for all sites be needed. When the feature is disabled globally then it should not be present in measurable settings.

If it's enabled, then we would show it in measurable settings.

If we use a system setting for the global flag then it'll be automatically configurable through the config file as well and would be then removed in the UI. I think that should do.

@sgiehl commented on October 14th 2020 Member

Seems due to the new UI test file, some tests moved between the splitting causing some tests to have other results. Will fix those later. But everything else can already be reviewed...

This Pull Request was closed on October 19th 2020
Powered by GitHub Issue Mirror