Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global list of Excluded IPs shows only one IP #16560

Closed
aloxe opened this issue Oct 12, 2020 · 1 comment · Fixed by #16566
Closed

Global list of Excluded IPs shows only one IP #16560

aloxe opened this issue Oct 12, 2020 · 1 comment · Fixed by #16566
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.0.0-RC

Comments

@aloxe
Copy link
Contributor

aloxe commented Oct 12, 2020

I am using matomo 4.0.0-b3

I recorded 3 IPs on 3 lines in the Global list of Excluded IPs global settings. Not all IPs are visible and the is no hint they are more.

On Firefox 81.0.1 MacOS:

  • When I load the page again, only the first record is visible.
  • When I focus on the textarea, only the first record is visible.
  • When I hit return, in the textarea all lines are visble including the empty line of the return
  • When I change the hight of the textarea to max-content, i only see two records
  • When I change the hight of the auto to auto, i only see two records

On Chrome 85.0.4183.121 MacOS

  • When I load the page again, only two records are visible.
  • When I focus on the textarea, only two records are visible.
  • When I hit return, in the textarea all lines are visble including the empty line of the return
  • When I change the hight of the textarea to max-content, i only see two records
  • When I change the hight of the textarea to auto, i only see two ½ records which is acceptable as I have visual feedback that there could be more.
@aloxe aloxe changed the title Global list of Excluded IPs shows only on IP Global list of Excluded IPs shows only one IP Oct 12, 2020
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 12, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Oct 12, 2020
@tsteur
Copy link
Member

tsteur commented Oct 12, 2020

Thanks @aloxe

I can reproduce this
image

@sgiehl sgiehl mentioned this issue Oct 13, 2020
Merged
@sgiehl sgiehl self-assigned this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging a pull request may close this issue.

Set minimal height of all textareas to 100px matomo-org/matomo
3 participants
@tsteur @sgiehl @aloxe