Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for PHP version above 8.0.0 #16539

Closed
wants to merge 1 commit into from
Closed

Check for PHP version above 8.0.0 #16539

wants to merge 1 commit into from

Conversation

luggesexe
Copy link
Contributor

Added suggested changes. #16536

@luggesexe
Copy link
Contributor Author

@tsteur & @Findus23

@sgiehl
Copy link
Member

sgiehl commented Oct 8, 2020

I guess that changes actually should target the branch 3.x-dev, so it will be included in the next 3.x version and not in Matomo 4.
@luggesexe could you recreate the PR based on the branch 3.x-dev and create the PR targeted to 3.x-dev branch?

@sgiehl
Copy link
Member

sgiehl commented Oct 15, 2020

@luggesexe I'll cherry-pick your commit to a local branch to recreate the PR against 3.x-dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants