don't mention PHP5 in messages #16538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
the
not-in-changelog
tsteur
reviewed
Oct 6, 2020
| @@ -49,10 +49,6 @@ public function findPhpBinary() | |||
| $bin = shell_exec('which php'); | |||
| } | |||
|
|
|||
| if (!$this->isValidPhpType($bin)) { | |||
| $bin = shell_exec('which php5'); | |||
There was a problem hiding this comment.
@Findus23 not sure if it's a thing but could do which php7 (and maybe which php8)?
There was a problem hiding this comment.
I don't think php7 exists on any (Debian) system, only php7.4 etc.
Not sure if listing all of them helps (if I understand it correctly this would matter if there was no php in PATH, but a php7.4 which seems quite rare).
sgiehl
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at #16536 I noticed that php5 was still mentioned in a few places, so I replaced them with a general
php.