Check for PHP version above 8.0.0 #16536
Conversation
| $piwik_currentPHPVersion = PHP_VERSION; | ||
| $minimumPhpInvalid = version_compare($piwik_minimumPHPVersion, $piwik_currentPHPVersion) > 0; | ||
| $maximumPHPInvalid = version_compare($piwik_maximumPHPVersion, $piwik_currentPHPVersion) >= 0; |
There was a problem hiding this comment.
Wait... no
$maximumPHPInvalid = version_compare($piwik_maximumPHPVersion, $piwik_currentPHPVersion) <= 0;
There was a problem hiding this comment.
I think that syntax is really confusing, so I'd go with the alternative one: (I hope I didn't mix it up)
https://www.php.net/manual/en/function.version-compare.php
$maximumPHPInvalid = version_compare($piwik_maximumPHPVersion, $piwik_currentPHPVersion, '>='); There was a problem hiding this comment.
I think it should be
$maximumPHPInvalid= version_compare($piwik_maximumPHPVersion, $piwik_currentPHPVersion, '<='); as we are checking if the version is below 8.0.0 rather than above. Otherwise this option should clear things up, yes.
| @@ -22,14 +22,21 @@ | |||
| // 3) composer.json (in two places) | |||
| // 4) tests/PHPUnit/Integration/ReleaseCheckListTest.php | |||
| $piwik_minimumPHPVersion = '7.2.5'; | |||
| $piwik_maximumPHPVersion = '8.0.0'; | |||
There was a problem hiding this comment.
Cheers @luggesexe would it need to be 8.0.0-dev? so it also matches PHP 8 beta versions etc
There was a problem hiding this comment.
Yes this should work. I will add it.
|
|
Yes, it runs before anything else, therefore it wouldn't be possible to translate it. Maybe adding a sentence referencing a help article? |
|
closing in favor of #16539. Also the source repo is not available anymore... |
Issue #16530