Fix selectable metrics in pie/bar charts for Events and Contents reports #16535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
fixpiechartmetrics
branch
4 times, most recently
from
7f62f2c
to
64966b4
Compare
sgiehl
force-pushed
the
fixpiechartmetrics
branch
from
64966b4
to
35f1f38
Compare
|
@sgiehl tested it and worked. However, some system tests are failing. I suppose this is unrelated to this PR? If so feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching Events or Content reports to a pie or bar chart the metric selection in the report currently only has
Visitsas option, which is actually not even available in some of the reports.Reason is, that selectable columns is filled with defaults if nothing is set.
Note: This might already have been an issue in Matomo 3.x