Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Matomo 3 add check for max PHP version #16530

Closed
tsteur opened this issue Oct 6, 2020 · 2 comments · Fixed by #16577
Closed

In Matomo 3 add check for max PHP version #16530

tsteur opened this issue Oct 6, 2020 · 2 comments · Fixed by #16577
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Oct 6, 2020

Matomo 3 won't and can't support PHP 8 (eg because of PHP DI not being compatible with PHP 8 and upgrading would require higher PHP version plus break compatibility for plugins).

Therefore we need to add a check to testMinimumPhpVersion.php for max supported PHP version.

If the PHP version is < 8.0.0 then we show a notice stating that Matomo 3 is not compatible with PHP 8 and that they should upgrade to Matomo 4. I suppose in version_compare as version number we should specify 8.0.0-dev for the check just in case someone is using PHP 8 alpha, beta or RC?

@Findus23 I think you were running Matomo with PHP 8. Do you remember if it was mostly working?

@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Oct 6, 2020
@tsteur tsteur added this to the 3.14.2 milestone Oct 6, 2020
@Findus23
Copy link
Member

Findus23 commented Oct 6, 2020

See also #16183

If I remember correctly, the Matomo application is working mostly fine, but if people have enabled PHP errors to be displayed in the output it breaks Matomo (as Deprecation warnings are shown before the output starts).

So I assume it should work well enough that people are able display the application and see the warning there or during the installer.

@tsteur
Copy link
Member Author

tsteur commented Oct 6, 2020

So ideally we'd test it in a PHP 8 environment. I see in #16536 there was already a PR made which me be good enough for now but ideally additionally we test using a PHP 8 installation if it was any usable/working then we could show the message differently. Plus in the installer.

We should test:

  • Does basic tracking work
  • Does basic reporting work
  • Does basic archiving work

If eg tracking still works we could remove #16536 again and only show a message in the UI so data will be still connected while using PHP 8.

@Findus23 Findus23 linked a pull request Oct 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants