Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unselecting metric in series picker #16527

Merged
merged 1 commit into from Oct 6, 2020
Merged

Fix unselecting metric in series picker #16527

merged 1 commit into from Oct 6, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 5, 2020

fixes #16526

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 5, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Oct 5, 2020
@MichaIng
Copy link
Contributor

MichaIng commented Oct 5, 2020

This alone does not fix the issue in my case.

Also:
Wouldn't it make sense to keep the popup menu open, until it is left with pointer or focus?
Currently it seems to be expected that the popup always hides when a selection is done, but probably one wants to go on selecting or de-selecting other graphs, or even one just wants to see the effect (tick/un-tick) in the metrics list?

@sgiehl
Copy link
Member Author

sgiehl commented Oct 6, 2020

@MichaIng did you clear the matomo cache & browser cache when testing?

@MichaIng
Copy link
Contributor

MichaIng commented Oct 6, 2020

Ah sorry, thought about browser cache and OPcache but forgot Matomo cache. All fine now, working nicely. I still think it would be good if the dropdown would stay open but I'll open a new issue for this.

@tsteur tsteur merged commit 4938e01 into 4.x-dev Oct 6, 2020
@tsteur tsteur deleted the fixmetricunselect branch October 6, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't unselect metrics from plot
3 participants