Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception if dividend or divisor is not a number for easier troubleshooting #16520

Merged
merged 5 commits into from Oct 5, 2020
Merged

Throw exception if dividend or divisor is not a number for easier troubleshooting #16520

merged 5 commits into from Oct 5, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 4, 2020

So we can ideally more easily have an idea of what values are being used. Otherwise the warning is only generic

@tsteur
Throw exception if dividend or divisor is not a number for easier tro…
12c2694 
…ubleshooting

So we can ideally more easily have an idea of what values are being used. Otherwise the warning is only generic
@tsteur tsteur added the Needs Review PRs that need a code review label Oct 4, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Oct 4, 2020
@tsteur tsteur merged commit 8868233 into 4.x-dev Oct 5, 2020
@tsteur tsteur deleted the quotientsaferound branch October 5, 2020 19:49
@tsteur tsteur mentioned this pull request Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl