Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrity Checker is incorrect for CustomVariables and Provider #16517

Closed
Findus23 opened this issue Oct 4, 2020 · 4 comments · Fixed by matomo-org/matomo-package#118 or #16734
Closed

Integrity Checker is incorrect for CustomVariables and Provider #16517

Findus23 opened this issue Oct 4, 2020 · 4 comments · Fixed by matomo-org/matomo-package#118 or #16734
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@Findus23
Copy link
Member

Findus23 commented Oct 4, 2020

reported in https://forum.matomo.org/t/integrity-check-misses-files-from-removed-customvariables-and-provider-plugins/38827

see also #16415
I am not entirely sure what the issue is exactly.

When downloading the beta zip, both the integrity checker lines for plugins/CustomVariables/.github/workflows/translations.yml and the file itself exists, but the rest of the plugin (the actual code) is missing.

Maybe this is caused by matomo-org/matomo-package#112
@Findus23 Findus23 added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 4, 2020
@Findus23 Findus23 added this to the 4.0.0-RC milestone Oct 4, 2020
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 5, 2020
@sgiehl sgiehl self-assigned this Oct 9, 2020
@sgiehl sgiehl mentioned this issue Oct 9, 2020
Merged
@MichaIng
Copy link
Contributor

MichaIng commented Nov 13, 2020 •
edited

@sgiehl
This is still an issue, I just updated from v4.0.0 RC2 to v4.0.0 RC3:

  • A Matomo update recovers files for the CustomVariables and Provider plugins, even that those have been uninstalled before.
  • They can be uninstalled again, but doing so leaves integrity check errors for CustomVariables: 
    Errors below may be due to a partial or failed upload of Matomo files.
--> Try to reupload all the Matomo files in BINARY mode. <--

Missing file: /var/www/matomo/plugins/CustomVariables/angularjs/manage-custom-vars/manage-custom-vars.controller.js
Missing file: /var/www/matomo/plugins/CustomVariables/angularjs/manage-custom-vars/manage-custom-vars.directive.html
Missing file: /var/www/matomo/plugins/CustomVariables/angularjs/manage-custom-vars/manage-custom-vars.directive.js
Missing file: /var/www/matomo/plugins/CustomVariables/angularjs/manage-custom-vars/manage-custom-vars.directive.less
Missing file: /var/www/matomo/plugins/CustomVariables/angularjs/manage-custom-vars/manage-custom-vars.model.js
Missing file: /var/www/matomo/plugins/CustomVariables/API.php
Missing file: /var/www/matomo/plugins/CustomVariables/Archiver.php
Missing file: /var/www/matomo/plugins/CustomVariables/Categories/CustomVariablesCategory.php
Missing file: /var/www/matomo/plugins/CustomVariables/Categories/CustomVariablesSubcategory.php
Missing file: /var/www/matomo/plugins/CustomVariables/Columns/Base.php
Missing file: /var/www/matomo/plugins/CustomVariables/Columns/CustomVariableName.php
Missing file: /var/www/matomo/plugins/CustomVariables/Columns/CustomVariableValue.php
Missing file: /var/www/matomo/plugins/CustomVariables/Commands/Info.php
Missing file: /var/www/matomo/plugins/CustomVariables/Commands/SetNumberOfCustomVariables.php
Missing file: /var/www/matomo/plugins/CustomVariables/config/config.php
Missing file: /var/www/matomo/plugins/CustomVariables/config/test.php
Missing file: /var/www/matomo/plugins/CustomVariables/config/tracker.php
Missing file: /var/www/matomo/plugins/CustomVariables/Controller.php
...

@tsteur tsteur reopened this Nov 13, 2020
@tsteur
Copy link
Member

tsteur commented Nov 16, 2020

maybe while we ship the plugins also within core we could mark the plugins as not uninstallable hard coded? might be enough adding them here? https://github.com/matomo-org/matomo/blob/4.0.0-rc3/core/Application/Kernel/PluginList.php#L34

@sgiehl
Copy link
Member

sgiehl commented Nov 16, 2020

@tsteur guess that makes sense

@MichaIng
Copy link
Contributor

Sounds reasonable if those are shipped with core intentionally. Does not make much sense to remove plugins which are restored on every update 🙂.

@tsteur tsteur assigned tsteur and unassigned sgiehl Nov 17, 2020
@tsteur tsteur mentioned this issue Nov 17, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
4 participants
@tsteur @sgiehl @Findus23 @MichaIng