@sgiehl opened this Pull Request on October 3rd 2020 Member

Tracking currently fails when a negative value is sent. As a negative value shoud not occur at all, I think it should be fine to simply ignore them.

refs https://forum.matomo.org/t/error-query-mysqli-stat-ement-execute-error-out-of-range-value-for-column-time-transfer/38826

@tsteur commented on October 3rd 2020 Member

@sgiehl is the negative value provided by the browser? what does a negative value mean in this case when the browser does that? If this negative value is set by the user then we would maybe rather want to throw an exception.

@MichaIng commented on October 4th 2020

At least this successfully works around the issue. But I agree that it might be worth having a look at why these values even can be negative. I compared the visit IDs of the error log and visitors log and found:

2x iOS Safari 14
5x MacOS Safari 14
ahh one time Firefox mobile on iOS 14
... and so on...

okay the same anonymized user IDs re-appear across multiple visit IDs, I guess it is clear that it is an Apple issue. Not sure if that Firefox was somehow tracked wrong, or if this only shows that Apple users mostly use Safari but it is an Apple issue, not a Safari issue.

@tsteur commented on October 4th 2020 Member

In the API let's throw an exception in general and then indeed lets also find out why the browser was sending a negative value and fix that bug and/or not send negative values in the JS

@sgiehl commented on October 5th 2020 Member

It seems some (older) browser versions have bugs around the performance timings causing some incorrect numbers 🤷
I'll update the PR, so the javascript won't send any performance timings if one of the timings seems to hold an obviously incorrect value.

@MichaIng commented on October 5th 2020

MacOS version were mostly 10.15, a few 10.14, so quite current. However, if you need to to get some more details about the failed visits, let me know, I can also revert the applied changes to get fresh errors.

@sgiehl commented on October 5th 2020 Member

I actually don't have a Mac. So I can't try to reproduce those problems 🤷
Maybe someone with MacOS/Safari can check for possible reasons...

@MichaIng commented on October 5th 2020

My wife has one, but is working with it nearly the whole day. Will see if I can get her to do a break an browse our website a bid. Also the browser console output might be interesting 🤔.

@tsteur commented on October 5th 2020 Member

btw @sgiehl we also have browserstack to test on any kind of operating system and browser. It can also resolve your local URLs so it's easy to debug.

@tsteur commented on October 6th 2020 Member

build js

@tsteur commented on October 6th 2020 Member

build js

This Pull Request was closed on October 6th 2020
Powered by GitHub Issue Mirror