@tolbon opened this Pull Request on October 2nd 2020 Contributor
@tsteur commented on October 5th 2020 Member

Thanks @tolbon Is there any particular reason for adding the typings and things we should look out for?

@tsteur commented on October 8th 2020 Member

@tolbon be great if you could have a look at previous comment

@tolbon commented on October 8th 2020 Contributor

Hi sorry for delay, I needed offscreen.
No no really, you target PHP 7.2. Php7.2 have typings...
It’s just a no critical class like Date. I think slowly move code with typing is a good things when you have big project like this.
Sometimes typing make appears some « bug » where PHPDoc say nothing. Like php docs say getSalt return a string but finally getSalt in test can return null (wrong test or wrong phpDocs ?).
I am totally open for suggestions/args 👍 I don’t have your vision or roadmap, Maybe you don’t target this (typing)

@tsteur commented on October 12th 2020 Member

Cheers @tolbon

This Pull Request was closed on October 12th 2020
Powered by GitHub Issue Mirror