Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning only in developer mode #16512

Merged
merged 1 commit into from Oct 28, 2020
Merged

Log warning only in developer mode #16512

merged 1 commit into from Oct 28, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 2, 2020

fixes #16200

Should be merged before final 4.0.0 release. So we maybe get some reports from RC users...

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 2, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Oct 2, 2020
@tsteur tsteur marked this pull request as ready for review October 28, 2020 21:41
@tsteur
Copy link
Member

tsteur commented Oct 28, 2020

@sgiehl I'll merge this already now as it will still trigger the exception in development mode anyway and we'll soon release the RC

@tsteur tsteur merged commit 1b2769d into 4.x-dev Oct 28, 2020
@tsteur tsteur deleted the subquerywarning branch October 28, 2020 21:44
@michalkleiner michalkleiner mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

Remove segment warning when no start date is set before release
2 participants
@sgiehl @tsteur