Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons alignment fix #16510

Closed
mattab opened this issue Oct 2, 2020 · 7 comments
Closed

Icons alignment fix #16510

mattab opened this issue Oct 2, 2020 · 7 comments
Assignees
@flamisz
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.14.2

Comments

@mattab
Copy link
Member

mattab commented Oct 2, 2020

Let's backport #16492 fix in 3.x as this is visible by default in many reports (pages, etc) and some people might use Matomo 3.x for 1 year or so
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Oct 2, 2020
@mattab mattab added this to the 3.14.2 milestone Oct 2, 2020
@sgiehl
Copy link
Member

sgiehl commented Oct 15, 2020

The fix in #16492 is a way to complex to back-port it to 3.x, as there have been a lot changes for it and font icons are now used instead of images...

@mattab
Copy link
Member Author

mattab commented Oct 18, 2020

@sgiehl ok, instead could we maybe patch it to revert what originally caused the icons to go misaligned?

@tsteur
Copy link
Member

tsteur commented Oct 18, 2020

@mattab that can't be done as it was the comparisons feature

@mattab
Copy link
Member Author

mattab commented Nov 27, 2020

@sgiehl could we instead do a quick fix / hack? It would be great if we could fix this and release 3.14.2 and feel good about 3.x LTS and hopefully not having to touch it afterwards

@flamisz flamisz self-assigned this Mar 8, 2021
@flamisz
Copy link
Contributor

flamisz commented Mar 8, 2021

Hi @mattab,

I created a PR for this. Really it's a kind of hack, playing with some css attributes, but looking better: (tested on firefox and chrome)

Screen Shot 2021-03-08 at 3 05 54 PM

@flamisz flamisz mentioned this issue Mar 8, 2021
Merged
10 tasks
@mattab
Copy link
Member Author

mattab commented Mar 8, 2021

Screenshot looks good to me @flamisz 👍

@flamisz
Copy link
Contributor

flamisz commented Apr 14, 2021 •
edited

the fix was merged, this can be closed now.

@flamisz flamisz closed this as completed Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flamisz flamisz

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.14.2
Development

No branches or pull requests
4 participants
@tsteur @mattab @sgiehl @flamisz