Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set consent removed cookie even when cookies are disabled #16507

Merged
merged 2 commits into from Oct 4, 2020
Merged

Always set consent removed cookie even when cookies are disabled #16507

merged 2 commits into from Oct 4, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 1, 2020 •
edited

The removed consent cookie would be a required / necessary cookie and should be stored IMO even if cookies are disabled since it is very much in the interest of the user and to have opt out work etc.

@tsteur
Copy link
Member Author

tsteur commented Oct 1, 2020

build js

@tsteur tsteur added this to the 4.0.0-RC milestone Oct 1, 2020
sgiehl
sgiehl approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess that makes sense....

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 4, 2020
@tsteur tsteur merged commit 9e10a15 into 4.x-dev Oct 4, 2020
@tsteur tsteur deleted the consentremovedcookiename branch October 4, 2020 21:44
@tsteur tsteur restored the consentremovedcookiename branch October 4, 2020 21:44
@tsteur tsteur deleted the consentremovedcookiename branch October 4, 2020 21:44
@tsteur tsteur mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl