Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve style of textareas in plugin settings #16493

Merged
merged 4 commits into from Sep 30, 2020
Merged

Improve style of textareas in plugin settings #16493

merged 4 commits into from Sep 30, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 29, 2020

fixes #16410

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 29, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Sep 29, 2020
@tsteur
Copy link
Member

tsteur commented Sep 29, 2020

@sgiehl I wonder if we could for example set a min-height to make it more clear that it's a textarea and several rows can be entered? It's otherwise not quite clear as it looks like a text field

image

Like a min height of 100px should do:

image

@sgiehl
Copy link
Member Author

sgiehl commented Sep 30, 2020

added a min height of 100px

@tsteur tsteur merged commit c8703f0 into 4.x-dev Sep 30, 2020
@tsteur tsteur deleted the textareastyle branch September 30, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

Styling problem when two textareas are shown after another in brute force settings
2 participants
@sgiehl @tsteur