Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when there are dimension updates they aren't shown in the update screen #16491

Closed
wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 29, 2020

To test it change eg the option_value of the option_name=version_log_visit.referer_type entry. Then reload Matomo. Without this update the SQL queries aren't shown.

…screen

To test it change eg the option_value of the `option_name=version_log_visit.referer_type` entry. Then reload Matomo. Without this update the SQL queries aren't shown.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 29, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Sep 29, 2020
@tsteur tsteur changed the title Fix when there are dimension updates they aren't shown in the update … Fix when there are dimension updates they aren't shown in the update screen Sep 29, 2020
@tsteur tsteur closed this Sep 29, 2020
@tsteur tsteur deleted the updatescreen branch September 29, 2020 06:51
@tsteur
Copy link
Member Author

tsteur commented Sep 29, 2020

will put a fix for this in #16490 as it requires more changes to avoid duplicate executing of updates etc

@tsteur tsteur removed the Needs Review PRs that need a code review label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant