Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The value for session.gc_probability now comes from the config files #16480

Merged
merged 1 commit into from Sep 29, 2020
Merged

The value for session.gc_probability now comes from the config files #16480

merged 1 commit into from Sep 29, 2020

Conversation

nina-py
Copy link
Contributor

@nina-py nina-py commented Sep 28, 2020 •
edited

Fixes #15274. Added session_gc_probability to the global config under [General]; the Session class now uses the config value instead of a hard-coded value.

@tsteur tsteur added the Needs Review PRs that need a code review label Sep 28, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 28, 2020
@nina-py nina-py changed the title Fixes #15274. The value for session.gc_probability now comes from the config files The value for session.gc_probability now comes from the config files Sep 28, 2020
diosmosis
diosmosis approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nina-py for another contribution!

@tsteur tsteur merged commit 214f0d1 into matomo-org:4.x-dev Sep 29, 2020
@nina-py nina-py deleted the issue-15274 branch September 29, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

Don't set session.gc_probality=1, instead read value from config
3 participants
@nina-py @diosmosis @tsteur