Replaced 'Piwik' with 'Matomo' in console output when creating extra Custom Dimensions #16475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsteur, just a quick question - for a straightforward fix like this that is not directly related to the issue I was working on, is a pull request enough or should I open an issue as well? |
|
Cheers again @nina-py A separate issue is not needed 👍 |
tsteur
added
the
Enhancement
tsteur
added
Bug
|
Thanks @tsteur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding extra custom dimensions to reproduce #16155, I noticed that the output from the console command still says "Your Piwik..." instead of "Your Matomo...". Updated the copy both in the output and in the corresponding tests.