Manage Dimensions: Sorting by ID is not numeric #16473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cheers @nina-py very appreciated 👍 |
|
No worries @tsteur! |
mattab
changed the title
mattab
changed the title
mattab
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason custom dimension ids are passed around as strings, and there is at least one place in the plugin JS code where they are converted to integers as needed - perhaps there is a good reason to keep them as strings almost everywhere else. According to AngularJS documentation, a getter function or an expression can be used instead of a field to order by, so I have added a .parseInt() method so that the ids are sorted properly. The performance hit of that is minimal given there won't be hundreds, or even dozens of custom dimensions in a typical Matomo setup.
fixes #16155