Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix percent symbol fails JavaScript Matomo code #16469

Merged
merged 3 commits into from Sep 30, 2020
Merged

Fix percent symbol fails JavaScript Matomo code #16469

merged 3 commits into from Sep 30, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 24, 2020

fix #16464

eg https://matomo.org/product-features/?pk_campaign=qwerty2%25-
results in results[1] = 'qwerty2%- which then fails using decodeWrapper but works using safeDecodeWrapper as it falls back to unescape.

fix #16464

eg `https://matomo.org/product-features/?pk_campaign=qwerty2%25-`
results in `results[1] = 'qwerty2%-` which then fails using decodeWrapper but works using safeDecodeWrapper as it falls back to unescape.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 24, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 24, 2020
@tsteur
Copy link
Member Author

tsteur commented Sep 24, 2020

build js

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add or adjust a test for that case?
Otherwise looks good.

@tsteur
Copy link
Member Author

tsteur commented Sep 30, 2020

Yes definitely 👍 added one

@tsteur tsteur merged commit 0e22ca2 into 4.x-dev Sep 30, 2020
@tsteur tsteur deleted the m16464 branch September 30, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percent symbol fails JavaScript matomo code
2 participants