Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved search translation string from the Feedback plugin to the CoreHome one #16460

Merged
merged 2 commits into from Sep 22, 2020
Merged

Moved search translation string from the Feedback plugin to the CoreHome one #16460

merged 2 commits into from Sep 22, 2020

Conversation

nina-py
Copy link
Contributor

@nina-py nina-py commented Sep 22, 2020

Fixes #15385.

@tsteur
Copy link
Member

tsteur commented Sep 22, 2020

Thanks for creating the PR @nina-py

Do you mind also moving the actual translation from plugins/Feedback/lang/en.json to plugins/CoreHome/lang/en.json and then we use CoreHome_Feedback as translation key?

This will ensure the translation key will work should feedback not be enabled.

@nina-py
Copy link
Contributor Author

nina-py commented Sep 22, 2020

@tsteur, done - thanks for pointing this out. Also updated the reference to the search string in plugins/CoreHome/angularjs/quick-access/quick-access.directive.html so that it works after these changes :).

@tsteur
Copy link
Member

tsteur commented Sep 22, 2020

Thanks @nina-py very appreciated

@tsteur tsteur merged commit da63393 into matomo-org:4.x-dev Sep 22, 2020
@tsteur tsteur added this to the 4.0.0 milestone Sep 22, 2020
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 22, 2020
@nina-py nina-py deleted the issue-15385 branch September 22, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

String not loaded in javascript while Feedback plugin is disabled
2 participants
@nina-py @tsteur