@nina-py opened this Pull Request on September 22nd 2020 Contributor

Fixes #15385.

@tsteur commented on September 22nd 2020 Member

Thanks for creating the PR @nina-py

Do you mind also moving the actual translation from plugins/Feedback/lang/en.json to plugins/CoreHome/lang/en.json and then we use CoreHome_Feedback as translation key?

This will ensure the translation key will work should feedback not be enabled.

@nina-py commented on September 22nd 2020 Contributor

@tsteur, done - thanks for pointing this out. Also updated the reference to the search string in plugins/CoreHome/angularjs/quick-access/quick-access.directive.html so that it works after these changes :).

@tsteur commented on September 22nd 2020 Member

Thanks @nina-py very appreciated

This Pull Request was closed on September 22nd 2020
Powered by GitHub Issue Mirror