Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some UI test failed screenshots aren't uploaded #16454

Closed
tsteur opened this issue Sep 21, 2020 · 2 comments
Closed

Some UI test failed screenshots aren't uploaded #16454

tsteur opened this issue Sep 21, 2020 · 2 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@tsteur
Copy link
Member

tsteur commented Sep 21, 2020 •
edited

See https://travis-ci.org/github/matomo-org/matomo/jobs/728828102#L1313 and https://travis-ci.org/github/matomo-org/matomo/jobs/728828101#L1139-L1214

none of them appear in https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/42529/

seems this is maybe happening when there's eg an issue to get the right selector? is it in this case maybe not even taking a screenshot and thus not uploading it?

@diosmosis do you maybe know why that is?
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 21, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 21, 2020
@diosmosis
Copy link
Member

@tsteur the expect was never reached in the test. There is still a screenshot taken, however (added w/ the puppeteer changes), see: https://travis-ci.org/github/matomo-org/matomo/jobs/728828102#L1501

It's visible in the processed screenshots directory, eg, https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/42529/processed/should_be_possible_to_show_recovery_codes_step1_authentication_failure.png

@tsteur
Copy link
Member Author

tsteur commented Sep 21, 2020

thanks that's what I thought

@tsteur tsteur closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

No branches or pull requests
2 participants
@diosmosis @tsteur