Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare session token in any case #16448

Merged
merged 5 commits into from Sep 30, 2020
Merged

Compare session token in any case #16448

merged 5 commits into from Sep 30, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 17, 2020

When the session token parameters are set, always compare the token as we expect it to be there in this case and also makes sure that if someone was to pass 0 or an empty string as token it will be still verified.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 17, 2020
@tsteur tsteur added this to the 4.0.0 milestone Sep 17, 2020
@tsteur tsteur modified the milestones: 4.0.0, 4.0.0-RC Sep 30, 2020
@sgiehl sgiehl merged commit f870c8e into 4.x-dev Sep 30, 2020
@sgiehl sgiehl deleted the tokenchecksession branch September 30, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl