New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix one click update test #16445
Fix one click update test #16445
Conversation
@diosmosis I suppose this PR is to fix #16430 ? |
@@ -20,7 +21,10 @@ public function getName() | |||
|
|||
public function getUrlToCheckForLatestAvailableVersion() | |||
{ | |||
return 'http://' . Url::getHost(false) . '/tests/resources/one-click-update-version.php'; | |||
$majorVersion = (int) Version::VERSION; | |||
$majorVersion += 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw once we are on Matomo 4 will we need to remove this one again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it should not be needed
@diosmosis the tests seem to fail now. Not sure if it's related to this? see eg https://travis-ci.org/github/matomo-org/matomo/jobs/727808766#L641 |
@tsteur That means nvm (the node version manager) isn't on that machine... might be a random failure, but related to travis-ci |
it's related, but it's a test issue only. whatever you experienced when upgrading to matomo 4 isn't reproduced by our oneclickupdate test. |
@diosmosis seems some tests are still failing otherwise seems good |
@tsteur this was a test issue it seems, not whatever you were experiencing on demo or cloud