Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one click update test #16445

Merged
merged 4 commits into from Sep 19, 2020
Merged

Fix one click update test #16445

merged 4 commits into from Sep 19, 2020

Conversation

diosmosis
Copy link
Member

@tsteur this was a test issue it seems, not whatever you were experiencing on demo or cloud

@diosmosis diosmosis added the Needs Review PRs that need a code review label Sep 16, 2020
@diosmosis diosmosis added this to the 4.0.0 milestone Sep 16, 2020
@tsteur
Copy link
Member

tsteur commented Sep 16, 2020

@diosmosis I suppose this PR is to fix #16430 ?

@@ -20,7 +21,10 @@ public function getName()

public function getUrlToCheckForLatestAvailableVersion()
{
return 'http://' . Url::getHost(false) . '/tests/resources/one-click-update-version.php';
$majorVersion = (int) Version::VERSION;
$majorVersion += 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw once we are on Matomo 4 will we need to remove this one again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it should not be needed

@tsteur
Copy link
Member

tsteur commented Sep 16, 2020

@diosmosis the tests seem to fail now. Not sure if it's related to this? see eg https://travis-ci.org/github/matomo-org/matomo/jobs/727808766#L641

@diosmosis
Copy link
Member Author

@tsteur That means nvm (the node version manager) isn't on that machine... might be a random failure, but related to travis-ci

@diosmosis
Copy link
Member Author

@diosmosis I suppose this PR is to fix #16430 ?

it's related, but it's a test issue only. whatever you experienced when upgrading to matomo 4 isn't reproduced by our oneclickupdate test.

@tsteur
Copy link
Member

tsteur commented Sep 17, 2020

@diosmosis seems some tests are still failing otherwise seems good

@diosmosis diosmosis merged commit 62fcad3 into 4.x-dev Sep 19, 2020
@diosmosis diosmosis deleted the fix-one-click-update branch September 19, 2020 12:55
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants