Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude more URL parameters by default to prevent collecting PII accidentally #16443

Open
tsteur opened this issue Sep 16, 2020 · 0 comments
Open
Labels
c: Privacy For issues that impact or improve the privacy.

Comments

@tsteur
Copy link
Member

tsteur commented Sep 16, 2020

Eg

password, username, zip zipcode,plz,email,name,lastname,firstname,billing,login,pass, orderid, ...

In Heatmaps plugin we have around 160 search keywords that we can use. Of course we wouldn't want to break any existing installation and we'd need to see how much it impacts performance to exclude that many URL parameters and would need to make it more efficient if needed... (the getQueryStringWithExcludedParameters method).

If we were to put them in the config or "Global list of Query URL parameters to exclude" then this might be quite a long list. Could also add a new option that when enabled adds these parameters on demand.

That PII is collected by accident without realising is otherwise a big risk for users.

fyi @mattab

@tsteur tsteur added the c: Privacy For issues that impact or improve the privacy. label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Privacy For issues that impact or improve the privacy.
Projects
None yet
Development

No branches or pull requests

2 participants