Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimension "Action URL" #16442

Merged
merged 1 commit into from Sep 30, 2020
Merged

Add dimension "Action URL" #16442

merged 1 commit into from Sep 30, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 15, 2020

refs DEV-1983

Note that this would need to be used usually with a segment filter because it would also include non-action URLs technically such as content impression URLs but content impressions/interactions aren't actions.

@tsteur tsteur added the Needs Review PRs that need a code review label Sep 15, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 15, 2020
@mattab
Copy link
Member

mattab commented Sep 16, 2020

Would it be possible to add a description for the dimension, that explains exactly what data it would return? (and mention that it includes non-action URLs such as content impression URLs (although content impressions/interactions aren't actions).)

@tsteur
Copy link
Member Author

tsteur commented Sep 16, 2020

@mattab no AFAIK it's not possible to provide a description for it. Happy to close the PR without merging if needed

@mattab
Copy link
Member

mattab commented Sep 16, 2020

Ok, forgot it wasn't a feature 🙈

Definitely it's worth reviewing & merging 👍

refs https://innocraft.atlassian.net/browse/DEV-1983

Note that this would need to be used usually with a segment filter because it would also include non-action URLs technically such as content impression URLs but content impressions/interactions aren't actions.
@tsteur tsteur merged commit 2b0de42 into 4.x-dev Sep 30, 2020
@tsteur tsteur deleted the dev1983 branch September 30, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants