Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split disabled PHP functions to not break table layout #16428

Merged
merged 1 commit into from Sep 13, 2020

Conversation

Findus23
Copy link
Member

grafik

@Findus23 Findus23 added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Sep 11, 2020
@tsteur
Copy link
Member

tsteur commented Sep 11, 2020

👍 Looks good @Findus23 only need to update the screenshot test

@Findus23
Copy link
Member Author

I see no UI changes that are caused by my change. https://builds-artifacts.matomo.org/matomo-org/matomo/info-system-check-width/42399/Diagnostics_page.png only changed the number of tables.

@tsteur tsteur merged commit b211b49 into 4.x-dev Sep 13, 2020
@tsteur tsteur deleted the info-system-check-width branch September 13, 2020 20:50
@mattab mattab added this to the 4.0.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants