disable generate:travis-yml when development mode is not enabled #16425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking this might break plugin tests. Because they would execute this command to compare if the generated travis yml is up to date and error if it's outdated. I don't think travis has development mode enabled? |
|
@Findus23 is this one important? if we merge this, then run some plugin tests in travis and see if it still works. might not be worth the effort since people would usually not use this command? |
|
Makes sense. I guess it is easier to just ignore the command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
johsin18/DevicePixelRatioMatomoPlugin#1 (comment)
This makes the
generate:travis-ymlcommand only available when development mode is enabled just like all other development-related commands.