Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matomo 4: Code to prevent server gone away in CronArchive is no longer there #16424

Closed
tsteur opened this issue Sep 11, 2020 · 1 comment · Fixed by #16432
Closed

Matomo 4: Code to prevent server gone away in CronArchive is no longer there #16424

tsteur opened this issue Sep 11, 2020 · 1 comment · Fixed by #16432
Assignees
@diosmosis
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@tsteur
Copy link
Member

tsteur commented Sep 11, 2020

It seems this code is no longer there @diosmosis ? https://github.com/matomo-org/matomo/pull/15619/files

Any chance we could add this back? Basically, after any climulti::request we need to execute that code to prevent possible server gone away errors.

We also need to add the same disconnectDB to runScheduledTasks in CronArchive to prevent server gone away errors.

    public function runScheduledTasks()
    {
        $this->logSection("SCHEDULED TASKS");

        if ($this->disableScheduledTasks) {
            $this->logger->info("Scheduled tasks are disabled with --disable-scheduled-tasks");
            return;
        }

        $this->disconnectDb()'
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 11, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Sep 11, 2020
@diosmosis
Copy link
Member

Not sure how this was removed, but wasn't on purpose. Will add it back.

@diosmosis diosmosis mentioned this issue Sep 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging a pull request may close this issue.

Add back db reconnect code to core:archive. matomo-org/matomo
2 participants
@diosmosis @tsteur