Simplify updater further should climulti not work #16419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be actually no reason to go through the dispatch process and instead we can directly call the method. This prevents various events being triggered during frontcontroller dispatch which may involve the API proxy etc.
tsteur
added
the
not-in-changelog
|
@diosmosis fyi I'll merge this. Tested it locally and looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be actually no reason to go through the dispatch process and instead we can directly call the method. This prevents various events being triggered during frontcontroller dispatch which may involve the API proxy etc.
@diosmosis can you have a look at this as well?